On 20/04/2023 10:53, Andre Przywara wrote: >> Bindings are always separate patches. checkpatch did not complain? >> >>> arch/arm/boot/dts/Makefile | 1 + >>> .../boot/dts/sun7i-a20-icnova-a20-adb4006.dts | 137 ++++++++++++++++++ >>> arch/arm/boot/dts/sun7i-a20-icnova-a20.dtsi | 63 ++++++++ >>> 4 files changed, 207 insertions(+) >>> create mode 100644 arch/arm/boot/dts/sun7i-a20-icnova-a20-adb4006.dts >>> create mode 100644 arch/arm/boot/dts/sun7i-a20-icnova-a20.dtsi >>> >>> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml >>> index 013821f4a7b8..12f0c236f17b 100644 >>> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml >>> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml >>> @@ -305,6 +305,12 @@ properties: >>> - const: allwinner,i12-tvbox >>> - const: allwinner,sun7i-a20 >>> >>> + - description: ICNova A20 ADB4006 >>> + items: >>> + - const: incircuit,icnova-a20-adb4006 >>> + - const: incircuit,icnova-a20 >>> + - const: allwinner,sun7i-a20 >>> + >>> - description: ICNova A20 SWAC >>> items: >>> - const: incircuit,icnova-a20-swac >>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >>> index 3cc32722c394..b6b408417261 100644 >>> --- a/arch/arm/boot/dts/Makefile >>> +++ b/arch/arm/boot/dts/Makefile >>> @@ -1321,6 +1321,7 @@ dtb-$(CONFIG_MACH_SUN7I) += \ >>> sun7i-a20-hummingbird.dtb \ >>> sun7i-a20-itead-ibox.dtb \ >>> sun7i-a20-i12-tvbox.dtb \ >>> + sun7i-a20-icnova-a20-adb4006.dtb \ >>> sun7i-a20-icnova-swac.dtb \ >>> sun7i-a20-lamobo-r1.dtb \ >>> sun7i-a20-linutronix-testbox-v2.dtb \ >>> diff --git a/arch/arm/boot/dts/sun7i-a20-icnova-a20-adb4006.dts b/arch/arm/boot/dts/sun7i-a20-icnova-a20-adb4006.dts >>> new file mode 100644 >>> index 000000000000..c1606c085e4e >>> --- /dev/null >>> +++ b/arch/arm/boot/dts/sun7i-a20-icnova-a20-adb4006.dts >>> @@ -0,0 +1,137 @@ >>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> >> Unusual license. Are you sure you are ok with GPLv5.0? > > Is it really unusual? This is literally the most commonly used dual license > for DTs, grep counts 252 users in arm and 573 users in arm64. > No, the most commonly used is GPL-2.0 (optionally OR MIT/BSD). GPLv3 and later appear, but it is actually weird to use it for kernel DTS where in general we said no to GPLv3. And my question is not the only one... just grep from responses from other maintainers. Best regards, Krzysztof
