On 20.04.2023 09:50, Krzysztof Kozlowski wrote:
> GPIO LEDs is not a bus, so drop unit-address and also start suffix
> numbering from 0:
>
> Warning (unit_address_vs_reg): /soc/leds/led@7: node has a unit name, but no reg or ranges property
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
Konrad
> arch/arm/boot/dts/qcom-ipq8064-rb3011.dts | 2 +-
> arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi | 10 +++++-----
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> index 47a5d1849c72..52eadefd2fb4 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> +++ b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> @@ -203,7 +203,7 @@ leds {
> pinctrl-0 = <&leds_pins>;
> pinctrl-names = "default";
>
> - led@7 {
> + led-0 {
> label = "rb3011:green:user";
> color = <LED_COLOR_ID_GREEN>;
> gpios = <&qcom_pinmux 33 GPIO_ACTIVE_HIGH>;
> diff --git a/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi b/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi
> index 411c8d63c38e..c5abe7151f14 100644
> --- a/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq8064-v1.0.dtsi
> @@ -92,34 +92,34 @@ leds {
> pinctrl-0 = <&leds_pins>;
> pinctrl-names = "default";
>
> - led@7 {
> + led-0 {
> label = "led_usb1";
> gpios = <&qcom_pinmux 7 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "usbdev";
> default-state = "off";
> };
>
> - led@8 {
> + led-1 {
> label = "led_usb3";
> gpios = <&qcom_pinmux 8 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "usbdev";
> default-state = "off";
> };
>
> - led@9 {
> + led-2 {
> label = "status_led_fail";
> function = LED_FUNCTION_STATUS;
> gpios = <&qcom_pinmux 9 GPIO_ACTIVE_HIGH>;
> default-state = "off";
> };
>
> - led@26 {
> + led-3 {
> label = "sata_led";
> gpios = <&qcom_pinmux 26 GPIO_ACTIVE_HIGH>;
> default-state = "off";
> };
>
> - led@53 {
> + led-4 {
> label = "status_led_pass";
> function = LED_FUNCTION_STATUS;
> gpios = <&qcom_pinmux 53 GPIO_ACTIVE_HIGH>;
