On Thu, Apr 20, 2023 at 05:34:57PM +0800, Nylon Chen wrote: > The `frac` variable represents the pulse inactive time, and the result of > this algorithm is the pulse active time. Therefore, we must reverse the > result. > > The reference is SiFive FU740-C000 Manual[0] > > Link: https://sifive.cdn.prismic.io/sifive/1a82e600-1f93-4f41-b2d8-86ed8b16acba_fu740-c000-manual-v1p6.pdf [0] > > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> Hmm, I don't recall reviewing or acking this patch. I do recalling doing it for 1/2 though: https://lore.kernel.org/linux-pwm/Y9len4GinXQ101xr@spud/ Please remove these from your next submission, I don't have any knowledge of this driver nor do I maintain it, thanks. > Signed-off-by: Nylon Chen <nylon.chen@xxxxxxxxxx> > Signed-off-by: Vincent Chen <vincent.chen@xxxxxxxxxx> This SoB is new too AFAICT and looks a bit odd. Should there be a Co-developed-by for Vincent? Thanks, Conor.
Attachment:
signature.asc
Description: PGP signature