Dear Stephen,
On 2023/4/19 上午 04:23, Stephen Boyd wrote:
Quoting Jacky Huang (2023-04-14 20:58:57)
diff --git a/drivers/clk/nuvoton/clk-ma35d1.h b/drivers/clk/nuvoton/clk-ma35d1.h
new file mode 100644
index 000000000000..28c60f081788
--- /dev/null
+++ b/drivers/clk/nuvoton/clk-ma35d1.h
@@ -0,0 +1,123 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * Copyright (C) 2023 Nuvoton Technology Corp.
+ * Author: Chi-Fang Li <cfli0@xxxxxxxxxxx>
+ */
+
+#ifndef __DRV_CLK_NUVOTON_MA35D1_H
+#define __DRV_CLK_NUVOTON_MA35D1_H
Is this header included in one C file? If so, remove the header file and
put the contents in the C file.
Both clk-ma35d1.c and clk-ma35d1-pll.c include this header file.
Do they both use all the defines from it? Move as much as possible out
of this header file and put them in the only C file that uses it.
Okay, I will try to eliminate the header file.
Best regards,
Jacky Huang
