On 18/04/2023 18:34, Krzysztof Kozlowski wrote: > On 04/04/2023 11:07, Stefan Windfeldt-Prytz wrote: >> This driver uses the continuous mode of the chip and integration >> time can be configured through sysfs. >> The constants for calculating lux value differs between packaging >> so it uses different compatible string for the two versions >> "ti,opt4001-picostar" and "ti,opt4001-sot-5x3" since the device id >> is the same. > > Thank you for your patch. There is something to discuss/improve. > >> + >> + indio_dev->channels = opt4001_channels; >> + indio_dev->num_channels = ARRAY_SIZE(opt4001_channels); >> + indio_dev->modes = INDIO_DIRECT_MODE; >> + indio_dev->name = chip->client->name; >> + >> + of_id = of_match_device(of_match_ptr(opt4001_of_match), &client->dev); > > ? Drop of_match_ptr Ah, this is old patch... so maybe you already did this. Best regards, Krzysztof
