On 2023/4/13 22:13, Krzysztof Kozlowski wrote: > On 13/04/2023 12:44, Minda Chen wrote: >> >> >> On 2023/4/12 16:26, Krzysztof Kozlowski wrote: >>> On 06/04/2023 03:52, Minda Chen wrote: >>>> This patchset adds USB driver and USB PHY for the StarFive JH7110 SoC. >>>> USB work mode is peripheral and using USB 2.0 PHY in VisionFive 2 board. >>>> The patch has been tested on the VisionFive 2 board. >>>> >>>> This patchset should be applied after the patchset [1], [2] and[3]: >>>> [1] https://patchwork.kernel.org/project/linux-riscv/cover/20230314124404.117592-1-xingyu.wu@xxxxxxxxxxxxxxxx/ >>>> [2] https://lore.kernel.org/all/20230315055813.94740-1-william.qiu@xxxxxxxxxxxxxxxx/ >>>> [3] https://patchwork.kernel.org/project/linux-phy/cover/20230315100421.133428-1-changhuang.liang@xxxxxxxxxxxxxxxx/ >>>> >>>> This patchset is base on v6.3-rc4 >>>> >>>> patch 1 is usb phy dt-binding document. >>>> patch 2 is Pcie PHY dt-binding document. >>>> patch 3 is USB 2.0 PHY driver. >>>> patch 4 is PCIe PHY driver. >>>> patch 5 is usb dt-binding document. >>>> patch 6 is the wrapper module driver of Cadence USB3. USB controller IP is Cadence USB3. >>>> patch 7 is USB device tree configuration. >>>> >>>> previous version >>>> --- >>>> v1: https://patchwork.kernel.org/project/linux-usb/cover/20230306095212.25840-1-minda.chen@xxxxxxxxxxxxxxxx/ >>>> v2: https://patchwork.kernel.org/project/linux-usb/cover/20230308082800.3008-1-minda.chen@xxxxxxxxxxxxxxxx/ >>> >>> This is v2. >>> >>>> v3: https://patchwork.kernel.org/project/linux-usb/cover/20230315104411.73614-1-minda.chen@xxxxxxxxxxxxxxxx/ >>>> >>>> changes >>>> v4: >>>> 1. (patch 1) split PCIe PHY dt-binding doc to patch 2. >>>> 2. (patch 2) PCIe PHY add stg and sys con configuration to dt-binding doc. >>>> 3. (patch 3) >>>> - split PCIe PHY driver to patch 4. >>>> - replace dr_mode to phy mode in jh7110_usb2_phy. >>>> 4. (patch 4) >>>> - Makefile and Kconfig sorted by alphabet sequence. >>>> - Add PCIe PHY stg and syscon PHY connection configuration >>>> for USB 3.0. >>>> 5. (patch 5) >>>> - commit message changed. >>>> - merge wrapper dts node and cdns3 node in example. >>>> - Add interrupts, reg, phy and dr_mode in property. >>>> - Add reset-name in property example. >>>> 6. (patch 6) >>>> - For dts node is merged, Using platform_device_alloc and >>>> platform_device_add to generate cadence sub device. >>>> - IOMEM and IRQ resource are passed to Cadence sub device. >>>> - Add PHY ops process for PHY dts setting can not be passed to >>>> Cadence USB driver. >>>> - remove the stg and sys USB 3.0 PHY configuration. >>>> - Change the suspend clock reset and clock enable sequence. >>>> - Get all reset and clock resources before enable them in >>>> cdns_clk_rst_init. >>>> - commit message changed. >>>> 7. (patch 7) >>>> - merge wrapper dts node and cdns3 node in usb dts. >>>> - move the stg and sys USB 3.0 PHY confiuration to >>>> PCIe PHY dts node. >>>> - commit message changed. >>>> - Add reset-names dts. >>>> >>>> v3: >>>> 1. Add patch 1 - 4. Add USB PHY driver and dt-binding doc. >>>> USB PHY codes are moved to patch 3 and patch 4. >>>> 2. (patch 5) >>>> - USB wrapper module dts document is moved to usb directory. >>>> - Remove the 'dr_mode' and 'starfive,usb2-only' setting. >>>> - Some dts format changes. dts binding check pass. >>>> 3. (patch 6) >>>> - Remove the PHY codes. >>>> - Search 'dr_mode' and phy setting from Cadence subnode. >>>> 4. (patch 7) >>>> - Add USB PHY dts configurion. >>>> - 'dr_mode' is moved to Cadence controller submode. >>>> >>>> v2: >>>> 1. (patch 5) dt-binding changes. The document example is the same as dts config. >>>> 2. (patch 6) using dev_err_probe and syscon_regmap_lookup_by_phandle_args function. Some formats changes >>>> 3. (patch 7) dts nodes sorted by the address after @ >>>> >>>> >>>> Minda Chen (7): >>>> dt-bindings: phy: Add StarFive JH7110 USB document >>>> dt-bindings: phy: Add StarFive JH7110 PCIe document >>>> phy: starfive: add JH7110 USB 2.0 PHY driver. >>>> phy: starfive: add JH7110 PCIE 2.0 PHY driver. >>>> dt-bindings: usb: Add StarFive JH7110 USB Bindings YAML schemas >>>> usb: cdns3: add StarFive JH7110 USB driver. >>>> riscv: dts: starfive: add USB dts configuration for JH7110 >>>> >>>> .../phy/starfive,jh7110-pcie-phy.yaml | 58 +++ >>>> .../bindings/phy/starfive,jh7110-usb-phy.yaml | 50 +++ >>>> .../bindings/usb/starfive,jh7110-usb.yaml | 136 +++++++ >>>> MAINTAINERS | 16 + >>>> .../jh7110-starfive-visionfive-2.dtsi | 7 + >>>> arch/riscv/boot/dts/starfive/jh7110.dtsi | 44 ++ >>>> drivers/phy/starfive/Kconfig | 22 + >>>> drivers/phy/starfive/Makefile | 2 + >>>> drivers/phy/starfive/phy-jh7110-pcie.c | 197 +++++++++ >>>> drivers/phy/starfive/phy-jh7110-usb.c | 161 ++++++++ >>>> drivers/usb/cdns3/Kconfig | 11 + >>>> drivers/usb/cdns3/Makefile | 1 + >>>> drivers/usb/cdns3/cdns3-starfive.c | 378 ++++++++++++++++++ >>>> drivers/usb/cdns3/core.h | 3 + >>>> 14 files changed, 1086 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/phy/starfive,jh7110-pcie-phy.yaml >>>> create mode 100644 Documentation/devicetree/bindings/phy/starfive,jh7110-usb-phy.yaml >>>> create mode 100644 Documentation/devicetree/bindings/usb/starfive,jh7110-usb.yaml >>>> create mode 100644 drivers/phy/starfive/phy-jh7110-pcie.c >>>> create mode 100644 drivers/phy/starfive/phy-jh7110-usb.c >>>> create mode 100644 drivers/usb/cdns3/cdns3-starfive.c >>>> >>>> >>>> base-commit: 0ec57cfa721fbd36b4c4c0d9ccc5d78a78f7fa35 >>>> prerequisite-patch-id: 24a6e3442ed1f5454ffb4a514cfd768436a87090 >>>> prerequisite-patch-id: 55390537360f25c8b9cbfdc30b73ade004f436f7 >>> >>> fatal: bad object 55390537360f25c8b9cbfdc30b73ade004f436f7 >>> >>> What commits do you reference? How are they helpful? >>> >> I use "git format-patch --base=(commit) to generate patchset. >> Maybe I set the wrong base commit. > > How are they helpful if these are private commits? >> Best regards, > Krzysztof > base-commit is not private commits. I should set base commit 197b6b60ae7bc51dd0814953c562833143b292aa. This is 6.3-rc4 commit. But I set 0ec57cfa721fbd36b4c4c0d9ccc5d78a78f7fa35. This is 6.3-rc4's previous commit.
