On Fri, Nov 21, 2014 at 1:43 AM, Joe Perches <joe@xxxxxxxxxxx> wrote: > On Fri, 2014-11-21 at 01:35 +0000, Grant Likely wrote: >> The overlay code needs to construct a new full_name from the parent name >> and the node name, but the current method has to allocate and then free >> an temporary string which is wasteful. Fix this problem by using vargs >> to pass in a format and arguments into __of_node_alloc(). > [] >> diff --git a/drivers/of/of_private.h b/drivers/of/of_private.h > [] >> @@ -61,7 +61,7 @@ static inline int of_property_notify(int action, struct device_node *np, >> * own the devtree lock or work on detached trees only. >> */ >> struct property *__of_prop_dup(const struct property *prop, gfp_t allocflags); >> -struct device_node *__of_node_alloc(const char *full_name, gfp_t allocflags); > > Please add > > __printf(1, 2) >> +struct device_node *__of_node_alloc(const char *fmt, ...); Fixed, thanks. g. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
