On 14/04/2023 22:40, Krzysztof Kozlowski wrote: > On 14/04/2023 14:48, Andreas Klinger wrote: >> Honeywell mpr is a pressure sensor series. There are many different models with different pressure >> ranges, units and transfer functions. >> >> The range and transfer function need to be set up in the dt. Therefore new properties >> honeywell,pmin-pascal, honeywell,pmax-pascal, honeywell,transfer-function are introduced. > > Please wrap commit message according to Linux coding style / submission > process (neither too early nor over the limit): > https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 > >> >> Add dt-bindings. >> >> Signed-off-by: Andreas Klinger <ak@xxxxxxxxxxxxx> > > Patches 2 and 3 are missing. At least they were mentioned in the > changelog but this is 1/1. > >> --- >> .../iio/pressure/honeywell,mprls0025pa.yaml | 93 +++++++++++++++++++ >> 1 file changed, 93 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml >> >> diff --git a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml >> new file mode 100644 >> index 000000000000..c0eb3c4be16f >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml >> @@ -0,0 +1,93 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/iio/pressure/honeywell,mprls0025pa.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Honeywell mpr series pressure sensor >> + >> +maintainers: >> + - Andreas Klinger <ak@xxxxxxxxxxxxx> >> + >> +description: | >> + Honeywell pressure sensor of model mprls0025pa. >> + >> + This sensor has an I2C and SPI interface. Only the I2C interface is implemented. >> + >> + There are many models with different pressure ranges available. The vendor calls them "mpr >> + series". All of them have the identical programming model and differ in the pressure range, unit > > Wrap according to Linux coding style, so at 80. > >> + and transfer function. >> + >> + To support different models one need to specify the pressure range as well as the transfer >> + function. Pressure range needs to be converted from its unit to pascal. >> + >> + The transfer function defines the ranges of numerical values delivered by the sensor. The minimal >> + range value stands for the minimum pressure and the maximum value also for the maximum pressure >> + with linear relation inside the range. >> + >> + Specifications about the devices can be found at: >> + https://prod-edam.honeywell.com/content/dam/honeywell-edam/sps/siot/en-us/products/sensors/ >> + pressure-sensors/board-mount-pressure-sensors/micropressure-mpr-series/documents/ >> + sps-siot-mpr-series-datasheet-32332628-ciid-172626.pdf >> + >> +properties: >> + compatible: >> + const: honeywell,mprls0025pa > > So this is one compatible for entire family of 96 separate devices. > Looks like reasonable compromise, although I will wait for Rob's > approval on that. > > Anyway you need to fix the coding style. ... and as Rob's bot pointed out, test it before sending. Best regards, Krzysztof
