On 14/04/2023 07:53, Andreas Kemnade wrote: > Document ROHM BD2606MVV LED driver devicetree bindings. Subject: no improvements and no comments from your side. Why? > > Signed-off-by: Andreas Kemnade <andreas@xxxxxxxxxxxx> > Reviewed-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx> > --- > .../bindings/leds/rohm,bd2606mvv.yaml | 81 +++++++++++++++++++ > 1 file changed, 81 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml > > diff --git a/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml b/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml > new file mode 100644 > index 0000000000000..14700a2e5feaa > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/rohm,bd2606mvv.yaml > @@ -0,0 +1,81 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/rohm,bd2606mvv.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ROHM BD2606MVV LED controller > + > +maintainers: > + - Andreas Kemnade <andreas@xxxxxxxxxxxx> > + > +description: > + The BD2606 MVV is a programmable LED controller connected via I2C that can > + drive 6 separate lines. Each of them can be individually switched on and off, > + but the brightness setting is shared between pairs of them. > + > + Datasheet is available at > + https://fscdn.rohm.com/en/products/databook/datasheet/ic/power/led_driver/bd2606mvv_1-e.pdf > + > +properties: > + compatible: > + const: rohm,bd2606mvv > + > + reg: > + maxItems: 1 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + enable-gpios: > + maxItems: 1 Drop maxItems. It cannot be different. > + description: GPIO pin to enable/disable the device. > + Best regards, Krzysztof