On 14/04/2023 10:30, Uwe Kleine-König wrote: > On Fri, Apr 14, 2023 at 10:21:05AM +0200, Krzysztof Kozlowski wrote: >> On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: >>> Add a compatible string for MediaTek Helio X10 MT6795's display PWM >>> block: this is the same as MT8173. >>> >>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> >>> --- >>> Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml >>> index 0088bc8e7c54..153e146df7d4 100644 >>> --- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml >>> +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml >>> @@ -22,7 +22,9 @@ properties: >>> - mediatek,mt8173-disp-pwm >>> - mediatek,mt8183-disp-pwm >>> - items: >>> - - const: mediatek,mt8167-disp-pwm >>> + - enum: >>> + - mediatek,mt6795-disp-pwm >>> + - mediatek,mt8167-disp-pwm >> >> This does not look correct. You do not add compatible, you replace >> breaking all mt8167-disp-pwm. At least it looks like this from context. > > I thought the old semantic to be: > > "mediatek,mt8167-disp-pwm" > > and the new > > "mediatek,mt6795-disp-pwm" or "mediatek,mt8167-disp-pwm" > > . What am I missing? The new is ok for mt6795 but it is not valid for mt8167. Best regards, Krzysztof
