On 12/04/2023 14:35, Matthias Brugger wrote: > > > On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: >> Add a compatible string for the MediaTek Helio X10 MT6795 SoC, using >> the same parameters as MT8183. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> >> --- >> .../display/mediatek/mediatek,dpi.yaml | 23 +++++++++++-------- >> 1 file changed, 14 insertions(+), 9 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml >> index d976380801e3..803c00f26206 100644 >> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml >> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml >> @@ -17,15 +17,20 @@ description: | >> >> properties: >> compatible: >> - enum: >> - - mediatek,mt2701-dpi >> - - mediatek,mt7623-dpi >> - - mediatek,mt8173-dpi >> - - mediatek,mt8183-dpi >> - - mediatek,mt8186-dpi >> - - mediatek,mt8188-dp-intf >> - - mediatek,mt8192-dpi >> - - mediatek,mt8195-dp-intf >> + oneOf: >> + - enum: >> + - mediatek,mt2701-dpi >> + - mediatek,mt7623-dpi >> + - mediatek,mt8173-dpi >> + - mediatek,mt8183-dpi >> + - mediatek,mt8186-dpi >> + - mediatek,mt8188-dp-intf >> + - mediatek,mt8192-dpi >> + - mediatek,mt8195-dp-intf >> + - items: >> + - enum: >> + - mediatek,mt6795-dpi >> + - const: mediatek,mt8183-dpi > > Shouldn't we declare both const: ? I assume it is likely the enum will grow. If this is reasonably anticipated, keep enum. Best regards, Krzysztof
