On Thu, 13 Apr 2023, AngeloGioacchino Del Regno wrote: > Il 13/04/23 13:06, Pavel Machek ha scritto: > > Hi! > > > > > Add basic code to turn on and off WLEDs and wire up MT6332 support > > > to take advantage of it. > > > This is a simple approach due to to the aforementioned PMIC supporting > > > only on/off status so, at the time of writing, it is impossible for me > > > to validate more advanced functionality due to lack of hardware. > > > > > > > @@ -467,14 +590,24 @@ static int mt6323_led_probe(struct platform_device *pdev) > > > goto put_child_node; > > > } > > > + is_wled = of_property_read_bool(child, "mediatek,is-wled"); > > > + > > > > This needs documenting in the binding, no? > > Yes, and I forgot to. Would it be okay if I send a supplementary patch out > of this series to document that since the bindings are already acked? You can add the support as part of a new patch. Please resend this series with it attached. -- Lee Jones [李琼斯]
