Hi Bryan, On Thu Apr 13, 2023 at 1:34 PM CEST, Bryan O'Donoghue wrote: > V5: > - Amagamates into once device, Heikki, Rob > > - Takes feedback on usage form Luka and Jianhua on VSafeV state transition detection > dev_err() -> dev_warn() > > - Orientation graph example and general expected bindings > I discussed offline with Bjorn the conclusions of the glink/sbu model. > The expected orientation-switch path is > connector/port@0 <-> phy/port@X <-> dp/port@0 > This can then be expanded to > connector/port@0 <-> redriver/port@0 <-> phy/port@X <-> dp/port@0 > > - Rob, Bjorn, Krzysztof > > - Data role > The data-role path is > connector/port@0 <-> dwc3/port@Y I believe I have adjusted my dts correctly for v5 compared to v4 but now the usb doesn't seem to work anymore in most cases. Only when having the phone already plugged in during boot in one orientation does USB come up, but also disappears once you replug the cable. I still see the same (or at least visually similar) messages when plugging in the USB cable or the USB stick but nothing more than that happens. Not that v4 worked perfectly on pm7250b+sm7225(/sm6350) but at least it worked in most cases as described in the emails there. Since the driver structure changed quite a bit, git diff isn't helpful here unfortunately. Don't think it matters but worth mentioning that sm6350 uses the new qmpphy bindings as described in qcom,sc8280xp-qmp-usb43dp-phy.yaml (this was also the case when testing v4 of this). Any idea? Regards Luca > > Previous set: > https://lore.kernel.org/linux-arm-msm/20230318121828.739424-1-bryan.odonoghue@xxxxxxxxxx/ > > Bootable: > https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/linux-next-23-04-12-pm8150b-tcpm-qcom-wrapper-typec-mux > > V4: > - Per Rob's input the pdphy and type-c appear as stadalone blocks > inside of the PMIC declaration which is a 1:1 mapping of PMIC hardware. > The TCPM virtual device is declared at the top-level. > https://lore.kernel.org/all/YY7p7jviA3ZG05gL@xxxxxxxxxxxxxxxxxx/ > > - Squashes the removal of the old driver with the addition of the new. - Heikki, Gunter > https://lore.kernel.org/all/YYVHcHC1Gm92VxEM@xxxxxxxxxxxxxxxxx/ > > - Reworked Dmitry's old patch for the QMP to account for file renames and > very minimal code-drift in the interregnum. > > - New yaml checks drive update of PMIC VBUS yaml > > - Some housekeeping on the sc7180 yaml side. sc7180 is not supported yet. > > - Expands and fixes the examples being added in the PMIC tcpm examples. > > Previous set: > https://lore.kernel.org/all/20211105033558.1573552-1-bryan.odonoghue@xxxxxxxxxx/ > > Bootable: > https://git.codelinaro.org/bryan.odonoghue/kernel/-/commits/linux-next-23-03-18-pm8150b-tcpm-qcom-wrapper-typec-mux > > V3: > Rob Herrings review > > - Drops use of remote-endpoint and ports to bind > tcpm to pdphy and typec replacing with phandle > > - Drops pmic-pdphy-* and pmic-typec-* from interrupt names > as suggested > > - Passes make dt_binding_check DT_CHECKER_FLAGS=-m > > BOD > - Noticed qcom_pmic_tcpm_pdphy_enable() was missing a > regulator_disable in case of an error, added. > > - qcom_pmic_tcpm_pdphy_probe() > devm_regulator_get() should come before regmap_get() > as is the case in qcom_pmic_tcpm_typec_probe() > > - Fixes compatible name in qcom,pmic-typec.yaml should > have read qcom,pm8150b-typec not qcom,pm8150b-usb-typec > > - Makes sure compat for core is "qcom,pm8150b-tcpm" in > docs and driver > > - Drops redundant return in void qcom_pmic_tcpm_pdphy_reset_off() > > Kernel Robot > - Drops unused variable debounced in qcom_pmic_tcpm_typec_get_cc() > > - Drops unsused variable orientation in qcom_pmic_tcpm_typec_set_cc() > > Latest bootable series can be found here: > Link: https://git.linaro.org/people/bryan.odonoghue/kernel.git/log/?h=usb-next-04-11-21-pm8150b-tcpm-v3 > > git diff usb-next-27-10-21-pm8150b-tcpm-v2 -- drivers/usb/typec/tcpm/qcom/ > git diff usb-next-27-10-21-pm8150b-tcpm-v2 -- Documentation/devicetree/bindings/usb/qcom,pmic* > > Previous set: > Link: https://lore.kernel.org/linux-usb/20211028164941.831918-1-bryan.odonoghue@xxxxxxxxxx/T/#t > > V2 resend: > - Adding omitted devicetree mailing list > > V2: > > Guenter Roeck's review > - Converts suggested qcom_pmic_tcpm_core.c into one-liners > > - Adds comment on how polarity is set in set_polarity() > > - Removes optional set_current_limit() > > - regmap_read/regmap_write > Reviwing other pm8150b/spmi drivers I then added in checks for all > reamap_read()/regmap_write() calls. > > - Fixes (type == TCPC_TX_CABLE_RESET || TCPC_TX_HARD_RESET) > thanks I definitely had the blinkers on there and didn't see that at all > > - qcom_pmic_tcpm_pdphy_pd_transmit_payload() > Treats regmap_read and read value as separate error paths > > - qcom_pmic_tcpm_pdphy_set_pd_rx() > Replaces boolean if/else with !on as suggested > > - Returns -ENODEV not -EINVAL on dev_get_regmap() error > > - qcom_pmic_tcpm_pdphy_pd_receive() > Guenter asks: "No error return ?" > bod: No we are inside an ISR here if we read data we pass that off to TCPM > if somehow we don't read the data - it is "junk" there's no value IMO > in pushing an error upwards back to the handler. > > Heikki Krogerus' review > - Includes Makefile I missed adding to my git index > > - Removes old Kconfig entry for remove driver > > Randy Dunlap's review > - Rewords drivers/usb/typec/tcpm/Kconfig > > - Drops tautology "aggregates togther" > > - Corrects spelling typos > > BOD's own review > - Drops redundant include of regmap.h in qcom_pmic_tcpm_core.c > > - Propogates qcom_pmic_tcpm_pdphy_disable() error upwards > > - Propogates pmic_pdphy_reset() error upwards > > - Drops error prints in qcom_pmic_tcpm_pdphy_pd_transmit_payload() > I had these in-place during development and don't recall them being > triggered even once, they are redundant, remove. > > Differences between the two can be seen by > git diff usb-next-27-10-21-pm8150b-tcpm-v2..usb-next-25-10-21-pm8150b-tcpm -- drivers/usb/typec/tcpm > > Latest bootable series can be found here: > Link: https://git.linaro.org/people/bryan.odonoghue/kernel.git/log/?h=usb-next-27-10-21-pm8150b-tcpm-v2 > > Previous set: > Link: https://lore.kernel.org/all/20211025150906.176686-1-bryan.odonoghue@xxxxxxxxxx/T/#t > > V1: > This series adds a set of yaml and a driver to bind together the type-c and > pdphy silicon in qcom's pm8150b block as a Linux type-c port manager. > > As part of that we retire the existing qcom-pmic-typec driver and fully > replicate its functionality inside of the new block with the additional > pdphy stuff along with it. > > An additional series will follow this one for the SoC and RB5 dtsi and dts > respectively. > > A bootable series can be found here > > Link: https://git.linaro.org/people/bryan.odonoghue/kernel.git/log/?h=usb-next-25-10-21-pm8150b-tcpm > > Bryan O'Donoghue (13): > dt-bindings: regulator: qcom,usb-vbus-regulator: Mark reg as required > dt-bindings: regulator: qcom,usb-vbus-regulator: Mark > regulator-*-microamp required > dt-bindings: phy: qcom,sc7180-qmp-usb3-dp-phy: Add orientation-switch > as optional > dt-bindings: phy: qcom,sc7180-qmp-usb3-dp-phy: Add ports as an > optional > dt-bindings: usb: Add Qualcomm PMIC Type-C YAML schema > dt-bindings: mfd: qcom,spmi-pmic: Add typec to SPMI device types > arm64: dts: qcom: sm8250: Define ports for qmpphy > orientation-switching > arm64: dts: qcom: pm8150b: Add a TCPM description > arm64: dts: qcom: qrb5165-rb5: Switch on Type-C VBUS boost > arm64: dts: qcom: qrb5165-rb5: Switch on basic TCPM > arm64: dts: qcom: qrb5165-rb5: Switch on TCPM usb-role-switching for > usb_1 > arm64: dts: qcom: qrb5165-rb5: Switch on TCPM orientation-switch for > usb_1_qmpphy > usb: typec: qcom: Add Qualcomm PMIC TCPM support > > Dmitry Baryshkov (1): > phy: qcom-qmp: Register as a typec switch for orientation detection > > .../bindings/mfd/qcom,spmi-pmic.yaml | 4 + > .../phy/qcom,sc7180-qmp-usb3-dp-phy.yaml | 40 ++ > .../regulator/qcom,usb-vbus-regulator.yaml | 10 +- > .../bindings/usb/qcom,pmic-typec.yaml | 169 ++++++ > MAINTAINERS | 10 + > arch/arm64/boot/dts/qcom/pm8150b.dtsi | 40 ++ > arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 57 +- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 13 + > drivers/phy/qualcomm/Kconfig | 8 + > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 80 ++- > drivers/usb/typec/Kconfig | 13 - > drivers/usb/typec/Makefile | 1 - > drivers/usb/typec/qcom-pmic-typec.c | 261 -------- > drivers/usb/typec/tcpm/Kconfig | 11 + > drivers/usb/typec/tcpm/Makefile | 1 + > drivers/usb/typec/tcpm/qcom/Makefile | 6 + > drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c | 362 +++++++++++ > .../typec/tcpm/qcom/qcom_pmic_typec_pdphy.c | 528 +++++++++++++++++ > .../typec/tcpm/qcom/qcom_pmic_typec_pdphy.h | 115 ++++ > .../typec/tcpm/qcom/qcom_pmic_typec_port.c | 560 ++++++++++++++++++ > .../typec/tcpm/qcom/qcom_pmic_typec_port.h | 194 ++++++ > 21 files changed, 2202 insertions(+), 281 deletions(-) > create mode 100644 Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml > delete mode 100644 drivers/usb/typec/qcom-pmic-typec.c > create mode 100644 drivers/usb/typec/tcpm/qcom/Makefile > create mode 100644 drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c > create mode 100644 drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c > create mode 100644 drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.h > create mode 100644 drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c > create mode 100644 drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.h > > -- > 2.39.2
