Hi Thierry, Many thanks for your review comments. > On Sat, Nov 22, 2014 at 07:23:30AM +0530, naidu.tellapati@xxxxxxxxx wrote: >> From: Naidu Tellapati <Naidu.Tellapati@xxxxxxxxxx> >> >> Add binding document for IMG Pulse Width Modulator (PWM) DAC present on the >> Pistachio SOC. The PWM DAC has four channels. >> >> Signed-off-by: Naidu Tellapati <Naidu.Tellapati@xxxxxxxxxx> >> Signed-off-by: Sai Masarapu <Sai.Masarapu@xxxxxxxxxx> >> Reviewed-by: Andrew Bresticker <abrestic@xxxxxxxxxxxx> >> --- >> No changes from v3. >> --- >> Documentation/devicetree/bindings/pwm/img-pwm.txt | 23 +++++++++++++++++++++ >> 1 files changed, 23 insertions(+), 0 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/pwm/img-pwm.txt >> >> diff --git a/Documentation/devicetree/bindings/pwm/img-pwm.txt b/Documentation/devicetree/bindings/pwm/img-pwm.txt >> new file mode 100644 >> index 0000000..d3828dd >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pwm/img-pwm.txt >> @@ -0,0 +1,23 @@ >> +*Imagination Technologies PWM DAC driver >> + >> +Required properties: >> + - compatible: Should be "img,pistachio-pwm" >> + - reg: Should contain physical base address and length of pwm registers. >> + - clocks: Must contain an entry for each entry in clock-names. >> + See ../clock/clock-bindings.txt for details. >> + - clock-names: input clock names. >> + Required elements: "pwm" and "sys". > I think it'd be useful to explain at least what the "sys" clock is. > "pwm" I'd assume that it clocks the IP block, but what does "sys" do? OK. Will add the description in the next patch set. The sys clock enables access to Internal configuration registers of PWM block. > Thierry Regards, Naidu. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
