On Tue, Apr 11, 2023 at 03:03:57PM -0500, Andrew Halaney wrote: > This is a forward port / upstream refactor of code delivered > downstream by Qualcomm over at [0] to enable the DWMAC5 based > implementation called EMAC3 on the sa8540p-ride dev board. > > From what I can tell with the board schematic in hand, > as well as the code delivered, the main changes needed are: > > 1. A new address space layout for dwmac5/EMAC3 MTL/DMA regs > 2. A new programming sequence required for the EMAC3 based platforms > > This series makes the changes above as well as other housekeeping items > such as converting dt-bindings to yaml, etc. > > As requested[1], it has been split up by compilation deps / maintainer tree. > I will post a link to the associated devicetree changes that together > with this series get the hardware functioning. > > Patches 1-3 are clean ups of the currently supported dt-bindings and > IMO could be picked up as is independent of the rest of the series to > improve the current codebase. They've all been reviewed in prior > versions of the series. > > Patches 5-7 are also clean ups of the driver and are worth picking up > independently as well. They don't all have explicit reviews but should > be good to go (trivial changes on non-reviewed bits). > > The rest of the patches have new changes, lack review, or are specificly > being made to support the new hardware, so they should wait until the > series as a whole is deemed ready to go by the community. Looks good to me! Tested-by: Brian Masney <bmasney@xxxxxxxxxx>
