On Friday 21 November 2014 20:58:01 Grygorii Strashko wrote: > Hi Kevin, > On 11/21/2014 10:06 AM, Geert Uytterhoeven wrote: > > On Fri, Nov 21, 2014 at 2:30 AM, Kevin Hilman <khilman@xxxxxxxxxx> wrote: > >> Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> writes: > >> > >> So now I'm confused about why the PM domain has to do anything special > >> if the presence/absence of the clocks is already handled by the DT. > > > > Just adding a clock property to a device node in DT doesn't enable the clock > > automatically, nor make it runtime-managed automatically. > > Compare this to e.g. pinctrl, where adding pinctrl properties to DT does enable > > them automatically, without the driver for the device having to care about it. > > > > Drivers interfacing external hardware typically do care about clocks, as they > > have to program clock generators for the external hardware interface (e.g. > > driving spi or i2c buses at specific frequencies). But is this a property of the driver or of the device? If this is true independent of the driver implementation, I don't see a problem with the approach of linking to a power-domain that automatically manages all clocks for the devices that need this, and requires the driver to manage them itself when there are any clocks that can't be handled with the generic clk-power-domain implementation. > > In non-DT case, we have possibility to divide clocks on "fck" and "opt" > (The way it can be done is not convenient, but it is - .con_id). > > For DT-case - no way now. Also, PM domains are not physically present on > Keystone 2 and GPD was selected as glue layer to integrate DT, pm_clk and > PM runtime all together (one big-fat-global PM domain :). > > So, I was able to find only following way to define "fck" clocks in DT: > clocks = <&papllclk>, <&clkcpgmac>, <&chipclk12>; > clock-names = "clk_pa", "clk_cpgmac", "cpsw_cpts_rft_clk"; > fck-clocks = <&papllclk>, <&clkcpgmac>; > As you can see - this will lead to data duplication in DT ( > > Any propositions are welcome? > > Unfortunately, It seems that if we would not able to find DT solution > then there will be following ways to move forward: > - "remove the power domain proxy from your drivers and use the clocks directly" > ((c) Arnd Bergmann). > [As possibility - It can be allowed to use clk_pm APIs by drivers] > - continue using platform specific implementations. Could the driver maybe identify the clocks that it wants to manage itself to the pm-domain code? If it's safe for a device to have the clock turned on at the default rate before loading the driver, any device that is connected to the simple clk-pm-domain code could have all its clocks start out as owned by the pm-domain, but then claim the clocks it needs to reprogram for itself and take them out of the pmdomain. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
