On 12.04.2023 09:19, Johan Hovold wrote: > On Wed, Apr 12, 2023 at 09:03:31AM +0200, Krzysztof Kozlowski wrote: >> On 12/04/2023 08:49, Johan Hovold wrote: >>> On Tue, Apr 11, 2023 at 06:58:33PM +0200, Krzysztof Kozlowski wrote: >>>> On 11/04/2023 16:23, Johan Hovold wrote: >>>>> On Fri, Apr 07, 2023 at 08:07:10PM +0200, Krzysztof Kozlowski wrote: >>>>>> Fix typo in drive-strength property name. >>>>> >>>>> In the future, please try to use the established commit-summary prefix. >>>>> In this case: >>>>> >>>>> arm64: dts: qcom: sc8280xp-x13s: >>>> >>>> Sure. >>>> >>>> commit ca1ce7207e53cfe69aee5002eb3795069668da53 >>>> Author: Johan Hovold <johan+linaro@xxxxxxxxxx> >>>> Date: Fri Aug 5 11:23:17 2022 +0200 >>>> >>>> arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: add alternate touchpad >>> >>> Yeah, we initially used a longer prefix (including "x13s" which was >>> missing in the Subject of this patch), but quite soon decided on using >>> the shorter >>> >>> arm64: dts: qcom: sc8280xp-x13s: >>> >>> instead. >> >> Thanks. Do you know if this rule applies to other long-names? I was >> usually keeping full name or shortening them by cutting end, but maybe I >> should cut the middle? >> >> sm8250-sony-xperia-edo-pdx206 >> sm8250-sony-xperia-edo >> sm8250-pdx206 I do sm8250-pdx206 or sm8250-edo for common dtsi changes Generally anything that contains the SoC name and isn't ambiguous works, IMO. And the more concise, the better. Konrad > > I would not call it a rule just yet, but I guess there are further cases > were this could have been used. Perhaps you can all decide to use it for > the other Qualcomm dts as well. > > For the X13s the, 'sc8280xp-x13s' is enough to uniquely define the > board and it mirrors 'sc8280xp-crd' (and using a shorter prefix makes > the commit logs easier to read). > > The general suggestion is still to check 'git log --oneline' for the > files in question and use what appears to be the (recent) common prefix. > > Johan
