On 2023/4/11 17:13, Conor Dooley wrote: > On Tue, Apr 11, 2023 at 04:32:55PM +0800, Mason Huo wrote: >> The VisionFive 2 board has an embedded pmic axp15060, >> which supports the cpu DVFS through the dcdc2 regulator. >> This patch enables axp15060 pmic and configs the dcdc2. >> >> Signed-off-by: Mason Huo <mason.huo@xxxxxxxxxxxxxxxx> >> --- >> .../starfive/jh7110-starfive-visionfive-2.dtsi | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >> index 2a6d81609284..df582bddae4b 100644 >> --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >> +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi >> @@ -114,6 +114,21 @@ &i2c5 { >> pinctrl-names = "default"; >> pinctrl-0 = <&i2c5_pins>; >> status = "okay"; >> + >> + pmic: axp15060_reg@36 { > > No underscores in node names please & "pmic" is the generic node name > for pmics. > > Cheers, > Conor. > Address it in next version. Thanks Mason >> + compatible = "x-powers,axp15060"; >> + reg = <0x36>; >> + >> + regulators { >> + reg_dcdc2: dcdc2 { >> + regulator-boot-on; >> + regulator-always-on; >> + regulator-min-microvolt = <500000>; >> + regulator-max-microvolt = <1540000>; >> + regulator-name = "vdd-cpu"; >> + }; >> + }; >> + }; >> }; >> >> &i2c6 { >> -- >> 2.39.2 >>