On Tue, 11 Apr 2023 at 18:09, Bjorn Andersson <andersson@xxxxxxxxxx> wrote: > > On Tue, Apr 11, 2023 at 05:43:51PM +0530, Bhupesh Sharma wrote: > > On Tue, 11 Apr 2023 at 17:28, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote: > > > > > > > > > > > > On 11.04.2023 09:28, Bhupesh Sharma wrote: > > > > Increase the l22 and l24 load used for uSD and eMMC VMMC. > > > > These need to be increased in order to prevent any voltage drop > > > > issues due to limited current happening during specific operations > > > > (e.g. write). > > > > > > > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> > > > > --- > > > You could have simply squashed this into the patch where > > > you enabled the controllers, so that that commit works > > > reliably for e.g. bisect > > > > Yes, but Bjorn asked me to send this separately (via irc). > > I am fine with squashing this with the previous patch [PATCH 2/3] as > > well, if Bjorn is OK with it. > > > > I was trying to say that I was fine with you just fixing the small thing > I had asked for and then you could send a separate patch for this when > you found the time. > > I can squash the two while applying, unless anyone else have any > concerns with the patches. Sounds good to me. Thanks for your help Bjorn with squashing the patches. Thanks, Bhupesh
