On Tue, 11 Apr 2023 09:12:01 +0800 Subhajit Ghosh <subhajit.ghosh@xxxxxxxxxxxxxx> wrote: > This series adds support for Avago (Broadcom) APDS9306 Ambient Light > Sensor. > > Datasheet: https://docs.broadcom.com/doc/AV02-4755EN > > Following features are supported: > - I2C interface > - 2 channels - als and clear > - Up to 20 bit resolution > - 20 bit data register for each channel > - Common Configurable items for both channels > - Integration Time > - Measurement Frequency > - Scale > - High and Low threshold interrupts for each channel > > - Selection of interrupt channel - als or clear > - Selection of interrupt mode - threshold or adaptive > - Level selection for adaptive threshold interrupts > - Persistence (Period) level selection for interrupts > > Signed-off-by: Subhajit Ghosh <subhajit.ghosh@xxxxxxxxxxxxxx> Hi Subhajit, No need to sign off a cover letter. The content isn't captured in the git tree anyway. For an RFC, I'd expect to see a clear statement in the cover letter of why it is an RFC rather than a formal patch submission. What specifically are you looking for comments on? Point us in the right direction and we might answer the questions quicker. Thanks, Jonathan > > Subhajit Ghosh (2): > dt-bindings: Document APDS9306 Light Sensor bindings > iio: light: Add support for APDS9306 Light Sensor > > .../bindings/iio/light/avago,apds9306.yaml | 47 + > drivers/iio/light/Kconfig | 11 + > drivers/iio/light/Makefile | 1 + > drivers/iio/light/apds9306.c | 1146 +++++++++++++++++ > 4 files changed, 1205 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/light/avago,apds9306.yaml > create mode 100644 drivers/iio/light/apds9306.c > > > base-commit: 0d3eb744aed40ffce820cded61d7eac515199165
