On Tue, Apr 11, 2023 at 04:27:23PM +0530, Devi Priya wrote: > > > On 4/5/2023 12:28 PM, Krzysztof Kozlowski wrote: > > On 04/04/2023 18:48, Devi Priya wrote: > > > Add bindings for PCIe hosts on IPQ9574 platform and allow > > > msi-parent property > > > > Missing full stop. Also in your other patches. > Okay > > > > > > > > Signed-off-by: Devi Priya <quic_devipriy@xxxxxxxxxxx> > > > --- > > > Changes in V2: > > > - Updated the commit message and dropped the aggr_noc entries > > > as it will be handled via interconnect driver > > > > > > .../devicetree/bindings/pci/qcom,pcie.yaml | 48 +++++++++++++++++++ > > > 1 file changed, 48 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > > index fb32c43dd12d..8657ab65008c 100644 > > > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > > @@ -26,6 +26,7 @@ properties: > > > - qcom,pcie-ipq8064-v2 > > > - qcom,pcie-ipq8074 > > > - qcom,pcie-ipq8074-gen3 > > > + - qcom,pcie-ipq9574 > > > - qcom,pcie-msm8996 > > > - qcom,pcie-qcs404 > > > - qcom,pcie-sa8540p > > > @@ -105,6 +106,8 @@ properties: > > > items: > > > - const: pciephy > > > + msi-parent: true > > > > Yes right, will rebase it on Mani's series. > But, as you have pointed out don't see the binding changes > in linux-next/master > Mani, could you please provide the tree details onto which the > binding change is merged? > Looks like the initial msi-map binding's patch [1] never got merged even though the dts patch went in. I'll squash the later fix to this, post v4 and CC you. - Mani [1] https://lore.kernel.org/all/20230102105821.28243-3-manivannan.sadhasivam@xxxxxxxxxx/ > > Isn't this conflicting with Mani's series: > > https://lore.kernel.org/all/20230108203340.GA229573-robh@xxxxxxxxxx/ > > https://lore.kernel.org/all/20230111123004.21048-1-manivannan.sadhasivam@xxxxxxxxxx/#t > > > > Although for some reason Mani's patch references non-existing commit and > > hunk... > > > > Best regards, > > Krzysztof > > > Best Regards, > Devi Priya -- மணிவண்ணன் சதாசிவம்