On Thu, 6 Apr 2023 21:43:57 +0200
Andreas Klinger <ak@xxxxxxxxxxxxx> wrote:
> Hi Jonathan,
>
> thanks for the extensive review. Most of it is clear but one questions remain.
> See below.
>
> Jonathan Cameron <jic23@xxxxxxxxxx> schrieb am Sa, 01. Apr 18:57:
> > > +static void mpr_reset(struct mpr_data *data)
> > > +{
> > > + if (data->gpiod_reset) {
> > > + gpiod_set_value(data->gpiod_reset, 0);
> > > + udelay(10);
> > > + gpiod_set_value(data->gpiod_reset, 1);
> > > + }
> >
> > If there isn't a reset signal, I'd like to see an attempt at least to write
> > all configuration registers to a known value (same as the one you'd
> > get after reset).
>
> There is no configuration register in the sensor I could write to. But maybe I
> didn't comprehend your point.
Ah. Devices is even simpler than I was anticipating. Which makes me wonder.
What does the reset actually do?
I checked the datasheet and reason to bother with this is about powersupplies
that don't come up fast enough. Fair enough. If someone hasn't wired
the reset I guess they are happy that the power on reset will work.
(4.0 Power support requirement)
Jonathan
>
> Andreas
>
