On 06/04/2023 22:26, Mark Brown wrote: > On Thu, Apr 06, 2023 at 07:38:19PM +0200, Krzysztof Kozlowski wrote: > >> Please squash all your three WM bindings (wm8711, wm8580 and wm8523) >> into one binding, if they are the same. Probably other WM from your >> previous submissions as well. We really do not need binding per each of >> this simple codecs. If they ever need to grow, then we can split them. > > At a minimum all of these devices should have separate regulator > specifications should they ever grow regulator support (and ideally > would have regulators specified in the binding from the get go). Good point. The bindings are incomplete that's why they look so similar. Therefore maybe we should not merge them, just like we do not add non-trivial-devices to trivial-devices schema, just because device is incomplete. > There's also no reason to restrict simple CODECs to a particular > manufacturer... True, we could extend it to other brands. Best regards, Krzysztof
