Hi Andrew, Andrew Lunn <andrew@xxxxxxx> writes: >> diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi b/arch/arm/boot/dts/armada-370-xp.dtsi >> index 2be9723bcdf3..8e65abf46fba 100644 >> --- a/arch/arm/boot/dts/armada-370-xp.dtsi >> +++ b/arch/arm/boot/dts/armada-370-xp.dtsi >> @@ -103,6 +103,10 @@ >> #size-cells = <1>; >> ranges = <0 MBUS_ID(0xf0, 0x01) 0 0x100000>; >> >> + pinctrl: pin-ctrl@18000 { >> + reg = <0x18000 0x38>; >> + }; >> + >> rtc@10300 { >> compatible = "marvell,orion-rtc"; >> reg = <0x10300 0x20>; > > We try to keep entries in these files in numeric address order. > So this should go after serial@12100 I should have remembered that. I had this comment a long time ago on an unrelated series. a+ -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html