On 06/04/2023 12:51, Sebastian Reichel wrote: > Hi Krzysztof, > > On Thu, Apr 06, 2023 at 09:45:11AM +0200, Krzysztof Kozlowski wrote: >> On 04/04/2023 16:53, Sebastian Reichel wrote: >>> Add compatible for RK3588 OHCI. As far as I know it's fully >>> compatible with generic-ohci. >>> >>> Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> >>> --- >>> .../devicetree/bindings/usb/generic-ohci.yaml | 18 ++++++++++++++++-- >>> 1 file changed, 16 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml >>> index a9ba7257b884..d84732a100ba 100644 >>> --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml >>> +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml >>> @@ -44,6 +44,7 @@ properties: >>> - hpe,gxp-ohci >>> - ibm,476gtr-ohci >>> - ingenic,jz4740-ohci >>> + - rockchip,rk3588-ohci >>> - snps,hsdk-v1.0-ohci >>> - const: generic-ohci >>> - enum: >>> @@ -68,8 +69,6 @@ properties: >>> maxItems: 2 >>> >>> clocks: >>> - minItems: 1 >>> - maxItems: 3 >> >> The constraints here should stay. > > dtbs_check complained about the 4 RK3588 clock entries if this > stays. That's why I moved them to the condition down below into > the else branch. Which is not what we want. We want the constraints here (the widest). Best regards, Krzysztof
