On Thu, Apr 06, 2023 at 11:01:37AM +0300, arinc9.unal@xxxxxxxxx wrote: > From: Arınç ÜNAL <arinc.unal@xxxxxxxxxx> > > The switch on MT7988 has got only port 6 as a CPU port. The only phy-mode > to be used is internal. Add this. > > Some bindings are incorrect for this switch now, so move them to more > specific places. > > Address the incorrect information of which ports can be used as a user > port. Any port can be used as a user port. > > Signed-off-by: Arınç ÜNAL <arinc.unal@xxxxxxxxxx> Acked-by: Daniel Golle <daniel@xxxxxxxxxxxxxx> > --- > .../bindings/net/dsa/mediatek,mt7530.yaml | 63 ++++++++++++++----- > 1 file changed, 46 insertions(+), 17 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > index 7045a98d9593..605888ce2bc6 100644 > --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > @@ -160,22 +160,6 @@ patternProperties: > "^(ethernet-)?port@[0-9]+$": > type: object > > - properties: > - reg: > - description: > - Port address described must be 5 or 6 for CPU port and from 0 to 5 > - for user ports. > - > - allOf: > - - if: > - required: [ ethernet ] > - then: > - properties: > - reg: > - enum: > - - 5 > - - 6 > - > required: > - compatible > - reg > @@ -186,9 +170,21 @@ $defs: > "^(ethernet-)?ports$": > patternProperties: > "^(ethernet-)?port@[0-9]+$": > + properties: > + reg: > + description: > + Port address described must be 5 or 6 for the CPU port. User > + ports can be 0 to 6. > + > if: > required: [ ethernet ] > then: > + properties: > + reg: > + enum: > + - 5 > + - 6 > + > if: > properties: > reg: > @@ -212,9 +208,21 @@ $defs: > "^(ethernet-)?ports$": > patternProperties: > "^(ethernet-)?port@[0-9]+$": > + properties: > + reg: > + description: > + Port address described must be 5 or 6 for the CPU port. User > + ports can be 0 to 6. > + > if: > required: [ ethernet ] > then: > + properties: > + reg: > + enum: > + - 5 > + - 6 > + > if: > properties: > reg: > @@ -235,6 +243,27 @@ $defs: > - 2500base-x > - sgmii > > + mt7988-dsa-port: > + patternProperties: > + "^(ethernet-)?ports$": > + patternProperties: > + "^(ethernet-)?port@[0-9]+$": > + properties: > + reg: > + description: > + Port address described must be 6 for the CPU port. User ports > + can be 0 to 3, and 6. > + > + if: > + required: [ ethernet ] > + then: > + properties: > + reg: > + const: 6 > + > + phy-mode: > + const: internal > + > allOf: > - $ref: dsa.yaml#/$defs/ethernet-ports > - if: > @@ -285,7 +314,7 @@ allOf: > compatible: > const: mediatek,mt7988-switch > then: > - $ref: "#/$defs/mt7530-dsa-port" > + $ref: "#/$defs/mt7988-dsa-port" > properties: > gpio-controller: false > mediatek,mcm: false > -- > 2.37.2 >
