On Wed, November 19, 2014 2:54 pm, Courtney Cavin wrote: > On Wed, Nov 19, 2014 at 07:52:49PM +0100, Kenneth Westfield wrote: >> From: Kenneth Westfield <kwestfie@xxxxxxxxxxxxxx> >> >> Model the LPASS audio hardware for the IPQ806X. >> >> Change-Id: Ide1aa0d09c23d4496aa9c40e3c9878a968261f11 > > As Kumar mentioned, please exclude this. > >> Signed-off-by: Kenneth Westfield <kwestfie@xxxxxxxxxxxxxx> >> Signed-off-by: Banajit Goswami <bgoswami@xxxxxxxxxxxxxx> > > Typically, the order of these SoB should match some sort of chain of delivery: > - The first should be the author of the patch > - The last should match the email source (you) <-- doesn't seem to be the case > >> --- >> arch/arm/boot/dts/qcom-ipq8064.dtsi | 33 +++++++++++++++++++++++++++++++++ >> 1 file changed, 33 insertions(+) >> >> diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi >> index 63b2146f563b541e4994697af5ee1bbb41a4abd1..0e5b3b625f0442964aa7fbbc993c6c818fe99041 100644 >> --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi >> +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi >> @@ -2,6 +2,7 @@ >> >> #include "skeleton.dtsi" >> #include <dt-bindings/clock/qcom,gcc-ipq806x.h> >> +#include <dt-bindings/clock/qcom,lcc-ipq806x.h> > > Neither this file nor an associated clock controller driver exists in > mainline. Is there some other series this depends on? > > -Courtney > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@xxxxxxxxxxxxxxxx > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel > Courtney Thank you for your comments. I will separately address each comment shortly. -- Kenneth Westfield Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
