On 2023/4/6 0:38, Conor Dooley wrote: > On Mon, Mar 20, 2023 at 03:32:14PM +0800, William Qiu wrote: > >> >>> Does not look like you tested the bindings. Please run `make >> >>> dt_binding_check` (see >> >>> Documentation/devicetree/bindings/writing-schema.rst for instructions). >> >>> >> >>> ... or your PLL clock controller was not tested. >> >>> >> >>> Best regards, >> >>> Krzysztof >> >>> >> >> Hi Krzysztof, >> >> >> >> I've already done`make dt_binding_check`, and get no error. So maybe PLL clock controller >> >> was not tested which I didn't add in this patch series. And PLL clock controller belongs >> >> to Xingyu Wu, I would tell him. >> > >> > What's confusing you do not allow here clock controller. > >> I'll add it then. > > What's the plan here William? > Can you sort something out with Xingyu Wu so that the dt-binding is > added in a complete manner? > In the meantime, gonna drop this series as "Changes Requested" from > patchwork. > > Cheers, > Conor. Hi Conor, After discussing with Xingyu, I will sort all of it and send a complete dt-binding today. Best regards, William
