On Mon, Apr 3, 2023 at 1:41 PM Edmund Berenson <edmund.berenson@xxxxxxxxx> wrote: > Add driver for maxim MAX7317 SPI-Interfaced 10 Port > GPIO Expander. > > v2: adjust driver to use regmap > > Co-developed-by: Lukasz Zemla <Lukasz.Zemla@xxxxxxxxxxxx> > Signed-off-by: Lukasz Zemla <Lukasz.Zemla@xxxxxxxxxxxx> > Signed-off-by: Edmund Berenson <edmund.berenson@xxxxxxxxx> Notwithstanding the other comments from Bartosz, this seems like a driver that should be using the regmap GPIO helper library. git grep GPIO_REGMAP will show you examples of other drivers that use this and how it is used. Yours, Linus Walleij