On Mon, Apr 03, 2023 at 07:22:45PM +0300, Cristian Ciocaltea wrote: > On 4/3/23 17:43, AngeloGioacchino Del Regno wrote: > > Il 03/04/23 16:32, Cristian Ciocaltea ha scritto: > >> On 4/3/23 16:10, Rob Herring wrote: > >>> > >>> On Mon, 03 Apr 2023 13:50:51 +0300, Cristian Ciocaltea wrote: > >>>> Convert the PWM fan bindings to DT schema format. > >>>> > >>>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx> > >>>> --- > >>>> .../devicetree/bindings/hwmon/pwm-fan.txt | 68 +---------- > >>>> .../devicetree/bindings/hwmon/pwm-fan.yaml | 109 > >>>> ++++++++++++++++++ > >>>> 2 files changed, 110 insertions(+), 67 deletions(-) > >>>> create mode 100644 > >>>> Documentation/devicetree/bindings/hwmon/pwm-fan.yaml > >>>> > >>> > >>> Running 'make dtbs_check' with the schema in this patch gives the > >>> following warnings. Consider if they are expected or the schema is > >>> incorrect. These may not be new warnings. > >>> > >>> Note that it is not yet a requirement to have 0 warnings for dtbs_check. > >>> This will change in the future. > >>> > >>> Full log is available here: > >>> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230403105052.426135-2-cristian.ciocaltea@xxxxxxxxxxxxx > >>> > >>> > >>> pwm-fan: 'cooling-max-state', 'cooling-min-state' do not match any of > >>> the regexes: 'pinctrl-[0-9]+' > >>> arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dtb > >>> arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dtb > >>> > >> > >> The only references to the offending cooling-{min|max}-state are located > >> in a few DTS files. Assuming they are obsolete, may I simply drop them? > >> > > > > If they're obsolete, you can mark them as `deprecated: true` in the > > binding, but > > dropping them entirely would be an ABI breakage, so no, you can't. > > >From the pwm-fan driver point of view, the properties are not supported > and I couldn't find any indication that they could have been used in the > past. > > Hence I'm not sure adding them to the binding is the proper way to > handle this issue. They can be omitted. Rob
