On 03/04/2023 11:06, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@xxxxxxx>
>
> Convert the binding doc to dt schema, and also fixed the
> example from fixed-regulator to regulator-fixed.
>
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> ---
>
> V2:
> License update
> Don't need to show providers
> Make example complete
> Decrease beeper hz
Why?
> Misc update
>
> .../devicetree/bindings/input/pwm-beeper.txt | 24 -----------
> .../devicetree/bindings/input/pwm-beeper.yaml | 42 +++++++++++++++++++
> 2 files changed, 42 insertions(+), 24 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/input/pwm-beeper.txt
> create mode 100644 Documentation/devicetree/bindings/input/pwm-beeper.yaml
>
> diff --git a/Documentation/devicetree/bindings/input/pwm-beeper.txt b/Documentation/devicetree/bindings/input/pwm-beeper.txt
> deleted file mode 100644
> index 8fc0e48c20db..000000000000
> --- a/Documentation/devicetree/bindings/input/pwm-beeper.txt
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -* PWM beeper device tree bindings
> -
> -Registers a PWM device as beeper.
> -
> -Required properties:
> -- compatible: should be "pwm-beeper"
> -- pwms: phandle to the physical PWM device
> -
> -Optional properties:
> -- amp-supply: phandle to a regulator that acts as an amplifier for the beeper
> -- beeper-hz: bell frequency in Hz
> -
> -Example:
> -
> -beeper_amp: amplifier {
> - compatible = "fixed-regulator";
> - gpios = <&gpio0 1 GPIO_ACTIVE_HIGH>;
> -};
> -
> -beeper {
> - compatible = "pwm-beeper";
> - pwms = <&pwm0>;
> - amp-supply = <&beeper_amp>;
> -};
> diff --git a/Documentation/devicetree/bindings/input/pwm-beeper.yaml b/Documentation/devicetree/bindings/input/pwm-beeper.yaml
> new file mode 100644
> index 000000000000..a3797f338f46
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/pwm-beeper.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/pwm-beeper.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: PWM beeper
> +
> +maintainers:
> + - Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> +
> +properties:
> + compatible:
> + const: pwm-beeper
> +
> + pwms:
> + description: Phandle to the physical PWM device
Drop description.
> + maxItems: 1
> +
> + amp-supply:
> + description: Phandle to a regulator that acts as an amplifier for the beeper
Drop "Phandle to a regulator that acts as "
> +
> + beeper-hz:
> + description: bell frequency in Hz
> + minimum: 1
> + maximum: 4
default is 1000, so how constraints can be lower than default? Also -
missing default.
Best regards,
Krzysztof
