Hi Mark, On Wed, 2014-11-19 at 18:04 +0000, Mark Rutland wrote: > On Wed, Nov 19, 2014 at 02:14:09PM +0000, Yingjoe Chen wrote: > > + if (type == IRQ_TYPE_LEVEL_LOW || type == IRQ_TYPE_EDGE_FALLING) { > > + if (type == IRQ_TYPE_LEVEL_LOW) > > + type = IRQ_TYPE_LEVEL_HIGH; > > + else > > + type = IRQ_TYPE_EDGE_RISING; > > + value |= (1 << offset); > > + } else > > + value &= ~(1 << offset); > > Nit: if one branch of an if statements is bracketed, both branches > should be. Please bracket the else case. OK, will change in next version. > > + writel(value, chip_data->intpol_base + reg_index * 4); > > + > > + data = data->parent_data; > > + ret = data->chip->irq_set_type(data, type); > > + spin_unlock_irqrestore(&chip_data->lock, flags); > > + return ret; > > +} > > + > > +static struct irq_chip mtk_sysirq_chip = { > > + .name = "MT_SYSIRQ", > > + .irq_mask = irq_chip_mask_parent, > > + .irq_unmask = irq_chip_unmask_parent, > > + .irq_eoi = irq_chip_eoi_parent, > > + .irq_set_type = mtk_sysirq_set_type, > > + .irq_retrigger = irq_chip_retrigger_hierarchy, > > + .irq_set_affinity = irq_chip_set_affinity_parent, > > +}; > > + > > +static int mtk_sysirq_domain_xlate(struct irq_domain *d, > > + struct device_node *controller, > > + const u32 *intspec, unsigned int intsize, > > + unsigned long *out_hwirq, > > + unsigned int *out_type) > > +{ > > + if (intsize < 3) > > + return -EINVAL; > > + > > + /* sysirq doesn't support PPI */ > > + if (intspec[0]) > > + return -EINVAL; > > + > > + *out_hwirq = intspec[1]; > > + *out_type = intspec[2] & IRQ_TYPE_SENSE_MASK; > > All of this is very strongly tied to the GIC, but the binding made it > sound like this was more generic (it didn't specify the number of cells > or their meaning). It doesn't look like we validate that this is > attached to a GIC. > > Do we expect this to only ever be attached to a GICv2? > > It would be nice to either make this generic or to describe the format > in the binding. This expect the parent to use the same interrupt cells format as GIC. I'll fix the binding to make this more clear. > Also, surely you expect intsize == 3 if you expect a GICv2? Likewise in > mtk_sysirq_domain_alloc. OK, will change that in next version. Joe.C -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html