On 31/03/2023 09:41, Srinivas Neeli wrote: > Versal watchdog driver uses window watchdog mode. Window watchdog Subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. > timer(WWDT) contains closed(first) and open(second) window with > 32 bit width. Write to the watchdog timer within predefined window > periods of time. This means a period that is not too soon and > a period that is not too late. > > This patch adds devicetree bindings for versal window watchdog device. Do not use "This commit/patch", but imperative mood. See: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > > Signed-off-by: Srinivas Neeli <srinivas.neeli@xxxxxxx> > --- > Changes in V3: > - Removed xlnx,close_percent property. > Changes in V2: > - Added watchdog ref > - Removed timeout-sec property > - Used 4 spaces for example indentation. > --- > .../bindings/watchdog/xlnx,versal-wwdt.yaml | 50 +++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml b/Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml > new file mode 100644 > index 000000000000..dea1e7c487d3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/xlnx,versal-wwdt.yaml > @@ -0,0 +1,50 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/xlnx,versal-wwdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Xilinx Versal window watchdog timer controller > + > +maintainers: > + - Neeli Srinivas <srinivas.neeli@xxxxxxx> > + > +description: > + Versal watchdog driver uses window watchdog mode. Window watchdog What is driver? If you mean Linux driver, then drop all references to it and rephrase to describe hardware. > + timer(WWDT) contains closed(first) and open(second) window with > + 32 bit width. Write to the watchdog timer within predefined window > + periods of time. This means a period that is not too soon and a > + period that is not too late. The WWDT has to be restarted within > + the open window time. If software tries to restart WWDT outside of > + the open window time period, it generates a reset. > + > +allOf: > + - $ref: /schemas/watchdog/watchdog.yaml# All other examples reference local watchdog.yaml. Don't do it differently than others (git grep watchdog.yaml) > + Best regards, Krzysztof
