Hi Krzysztof,
On 03/04/2023 09:49, Krzysztof Kozlowski wrote:
Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Fabio Estevam <festevam@xxxxxxx>
---
Changes since v1:
- Added samsung,mipi-dsim.yaml entry to MAINTAINERS file (Jagan)
- Added Marek Szyprowski entry to the samsung,mipi-dsim.yaml
maintainers section (Jagan)
- Mention that i.MX8M Plus is also supported (Marek)
- Remove endpoint@0 description as it only has one endpoint (Marek)
Where is the changelog from original submission? How your v1 differs
form it? Or did you just ignore all the feedback?
I'm sorry, but it was not my intention to ignore any feedback.
Which feedback are you referring to specifically?
Some more context: last week I sent a patch adding a new property
for exynos_dsim.txt and you asked me to convert it to yaml first:
https://lore.kernel.org/all/ff66c8b9-c7f7-1eb2-c730-4812b7ff6824@xxxxxxxxxx/#t
Jagan pointed out an earlier submission he did in 2021:
https://lore.kernel.org/all/20210704090230.26489-9-jagan@xxxxxxxxxxxxxxxxxxxx/
That was my starting point.
+ phys:
+ maxItems: 1
+ description: phandle to the phy module representing the DPHY
OK, so you did ignore the feedback.
Not intentionally.
NAK, go through the feedback and implement it.
Just found this feedback from Rob about Jagan's initial submission:
https://lore.kernel.org/all/20210712151322.GA1931925@xxxxxxxxxxxxxxxxxx/
I can send a new version that takes Rob's feedback into account.
Were there any further versions/feedback that were submitted? Can't find
them on lore.
In another reply, you mention that this should be v13. I could not find
previous versions of the yaml submission.
Please advise.
Thanks,
Fabio Estevam
