Hi Sebastian,
On 28.02.23 23:32, Jakob Hauser wrote:
Enable high impedance mode to reduce power consumption. However, it needs to be
disabled in case of charging or OTG mode.
Tested-by: Raymond Hackley <raymondhackley@xxxxxxxxxxxxxx>
Signed-off-by: Jakob Hauser <jahau@xxxxxxxxxxxxxx>
---
drivers/power/supply/rt5033_charger.c | 47 ++++++++++++++++++++++++++-
1 file changed, 46 insertions(+), 1 deletion(-)
...
Raymond (in copy) did some tests on the flash LEDs, which are also
managed by the rt5033 chip. There is no driver for leds-rt5033 yet but
Raymond got the rt5033 LEDs running via the similar driver leds-sgm3140.
However, to get the flash LEDs working, he had to disable the high
impedance mode of rt5033.
I implemented the use of high impedance mode by this patch to improve
power saving. It's kind of a sleep mode. Although it's not clear how
much power it does save, it's generally worth trying to improve power
saving on mobile devices as far as possible.
As it now turns out that the use of high impedance mode might complicate
the handling of the flash LEDs, I would drop this patch in the next
version v2 of the patchset. Let's skip this power saving attempt for
now. It still can be added at a later date as an improvement.
Kind regards,
Jakob
