On 31/03/2023 21:59, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > > Add a new compatible for the QMP UFS PHY found on sa8775p platforms and > update the clocks property to accommodate three clocks. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > --- > .../phy/qcom,sc8280xp-qmp-ufs-phy.yaml | 34 ++++++++++++++++--- > 1 file changed, 30 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml > index 64ed331880f6..a414b2c2d9cc 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-ufs-phy.yaml > @@ -16,6 +16,7 @@ description: > properties: > compatible: > enum: > + - qcom,sa8775p-qmp-ufs-phy > - qcom,sc8280xp-qmp-ufs-phy > - qcom,sm6125-qmp-ufs-phy > - qcom,sm8550-qmp-ufs-phy > @@ -24,12 +25,12 @@ properties: > maxItems: 1 > > clocks: > - maxItems: 2 > + minItems: 2 > + maxItems: 3 > > clock-names: > - items: > - - const: ref > - - const: ref_aux Keep it here and add qref. We want to encourage the same clocks everywhere it is possible. Otherwise people will add soon 'q_ref' or 'ref_q' for their variants as third clock. > + minItems: 2 With this. > + maxItems: 3 But without this. > > power-domains: > maxItems: 1 > @@ -51,6 +52,31 @@ properties: > "#phy-cells": > const: 0 > > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,sa8775p-qmp-ufs-phy > + then: > + properties: > + clocks: > + maxItems: 3 > + clock-names: > + items: Instead maxItems: 3 > + - const: ref > + - const: ref_aux > + - const: qref > + else: > + properties: > + clocks: > + maxItems: 2 > + clock-names: > + items: Instead maxItems: 2 > + - const: ref > + - const: ref_aux > + > required: > - compatible > - reg Best regards, Krzysztof
