On 01/04/2023 11:09, Andreas Klinger wrote: > Honeywell mpr is a pressure sensor family. There are many different > types with different pressure ranges. The range needs to be set up in > the dt. Therefore new properties honeywell,pmin and honeywell,pmax are > introduced. > > Add dt-bindings. > > Signed-off-by: Andreas Klinger <ak@xxxxxxxxxxxxx> > --- > .../bindings/iio/pressure/honeywell,mpr.yaml | 74 +++++++++++++++++++ > 1 file changed, 74 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/pressure/honeywell,mpr.yaml > > diff --git a/Documentation/devicetree/bindings/iio/pressure/honeywell,mpr.yaml b/Documentation/devicetree/bindings/iio/pressure/honeywell,mpr.yaml > new file mode 100644 > index 000000000000..d6fad6f841cf > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/pressure/honeywell,mpr.yaml > @@ -0,0 +1,74 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/pressure/honeywell,mpr.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Honeywell mpr pressure sensor > + > +maintainers: > + - Andreas Klinger <ak@xxxxxxxxxxxxx> > + > +description: | > + Honeywell pressure sensor of type mpr. This sensor has an I2C and SPI interface. Only the I2C Doesn't look wrapped according to Linux coding style (see Coding style). > + interface is implemented. > + > + There are many subtypes with different pressure ranges available. Therefore the minimum and > + maximum pressure values of the specific sensor needs to be specified in Pascal. > + > + Specifications about the devices can be found at: > + https://prod-edam.honeywell.com/content/dam/honeywell-edam/sps/siot/en-us/products/sensors/ \ > + pressure-sensors/board-mount-pressure-sensors/micropressure-mpr-series/documents/ \ > + sps-siot-mpr-series-datasheet-32332628-ciid-172626.pdf Lines are not continued, so drop \ > + > +properties: > + compatible: > + const: honeywell,mpr You need device specific compatible, not some generic one. Rename also then the filename (should match the compatible). > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + reset-gpios: > + description: > + Optional GPIO for resetting the device. If not present the device is not resetted. Are you sure it is wrapped properly? > + maxItems: 1 > + > + honeywell,pmin: > + description: > + Minimum pressure value the sensor can measure in pascal. Use standard unit suffix: https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/property-units.yaml > + $ref: /schemas/types.yaml#/definitions/uint32 > + > + honeywell,pmax: > + description: > + Maximum pressure value the sensor can measure in pascal. > + $ref: /schemas/types.yaml#/definitions/uint32 Same. Why these values are suitable for DT? Does it depend on type of sensor (thus it is implied from compatible) or on system setup? > + > +required: > + - compatible > + - reg > + - honeywell,pmin > + - honeywell,pmax > + Best regards, Krzysztof
