On 30/03/2023 21:44, kernel test robot wrote: > I love your patch! Perhaps something to improve: > All warnings (new ones prefixed by >>): > >>> drivers/firmware/smccc/em.c:142:5: warning: no previous prototype for 'arm_smccc_em_dt_alloc_tbl_entry' [-Wmissing-prototypes] > 142 | int arm_smccc_em_dt_alloc_tbl_entry(struct device_node *np, const char *name, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ It's just missing a static. Fixed locally. Thanks, James