Hi Sebastian,
On 3/18/23 00:23, Sebastian Reichel wrote:
> SPI device drivers should also have a SPI ID table.
>
> Signed-off-by: Sebastian Reichel <sre@xxxxxxxxxx>
> ---
> drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
> index bbc4569cbcdc..e4d8dea1db36 100644
> --- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
> +++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c
> @@ -394,6 +394,12 @@ static void st7789v_remove(struct spi_device *spi)
> drm_panel_remove(&ctx->panel);
> }
>
> +static const struct spi_device_id st7789v_spi_id[] = {
> + { "st7789v" },
Minor suggestion: The format
static const struct spi_device_id st7789v_spi_id[] = {
{
.name = "st7789v",
},
{ }
};
is more verbose, but can be extended easily.
> + { }
> +};
> +MODULE_DEVICE_TABLE(spi, st7789v_spi_id);
> +
> static const struct of_device_id st7789v_of_match[] = {
> { .compatible = "sitronix,st7789v" },
> { }
The same holds for this structure here (you may want to consider this
when adding the .data field in patch 6/7.
Best regards,
Michael
> @@ -403,6 +409,7 @@ MODULE_DEVICE_TABLE(of, st7789v_of_match);
> static struct spi_driver st7789v_driver = {
> .probe = st7789v_probe,
> .remove = st7789v_remove,
> + .id_table = st7789v_spi_id,
> .driver = {
> .name = "st7789v",
> .of_match_table = st7789v_of_match,
