2014-11-21 2:18 GMT+08:00 Rob Herring <robherring2@xxxxxxxxx>: > On Thu, Nov 20, 2014 at 10:59 AM, Vincent Yang > <vincent.yang.fujitsu@xxxxxxxxx> wrote: >> 2014-11-20 23:22 GMT+08:00 Rob Herring <robherring2@xxxxxxxxx>: >>> On Thu, Nov 20, 2014 at 6:38 AM, Vincent Yang >>> <vincent.yang.fujitsu@xxxxxxxxx> wrote: >>>> This patch adds new host controller driver for >>>> Fujitsu SDHCI controller f_sdh30. >>>> >>>> Signed-off-by: Andy Green <andy.green@xxxxxxxxxx> >>>> Signed-off-by: Vincent Yang <Vincent.Yang@xxxxxxxxxxxxxx> >>>> Signed-off-by: Tetsuya Takinishi <t.takinishi@xxxxxxxxxxxxxx> >>>> --- >>>> .../devicetree/bindings/mmc/sdhci-fujitsu.txt | 35 +++ >>>> drivers/mmc/host/Kconfig | 9 + >>>> drivers/mmc/host/Makefile | 1 + >>>> drivers/mmc/host/sdhci_f_sdh30.c | 319 +++++++++++++++++++++ >>>> 4 files changed, 364 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-fujitsu.txt >>>> create mode 100644 drivers/mmc/host/sdhci_f_sdh30.c >>>> >>>> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-fujitsu.txt b/Documentation/devicetree/bindings/mmc/sdhci-fujitsu.txt >>>> new file mode 100644 >>>> index 0000000..a1e0b64 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/mmc/sdhci-fujitsu.txt >>>> @@ -0,0 +1,35 @@ >>>> +* Fujitsu SDHCI controller >>>> + >>>> +This file documents differences between the core properties in mmc.txt >>>> +and the properties used by the sdhci_f_sdh30 driver. >>>> + >>>> +Required properties: >>>> +- compatible: "fujitsu,mb86s70-sdh30" >>> >>> It would be nice to have sdhci in the name to indicate it is an SDHCI >>> controller. >> >> Yes, we will update it to "fujitsu,sdhci-f-sdh30" >> Thanks for your review! > > Not really what I had in mind as you are then dropping the chip name. > Perhaps "fujitsu,mb86s70-sdhci-3.0". Is 3.0 the SD spec version or IP > version? If the former, I think I'd drop it as IIRC that is available > in a register. We will update it to "fujitsu,mb86s70-sdhci-3.0" as you suggest because 3.0 is IP version Thanks for your review! Vincent > > Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
