On 30/03/2023 20:24, Nikita Bondarenko wrote:
> Signed-off-by: Nikita Bondarenko <n2h9z4@xxxxxxxxx>
Use subject prefixes matching the subsystem (which you can get for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching).
Missing commit msg.
> ---
> .../bindings/watchdog/brcm,kona-wdt.txt | 15 -------
> .../bindings/watchdog/brcm,kona-wdt.yaml | 45 +++++++++++++++++++
> 2 files changed, 45 insertions(+), 15 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/watchdog/brcm,kona-wdt.txt
> create mode 100644 Documentation/devicetree/bindings/watchdog/brcm,kona-wdt.yaml
>
> diff --git a/Documentation/devicetree/bindings/watchdog/brcm,kona-wdt.txt b/Documentation/devicetree/bindings/watchdog/brcm,kona-wdt.txt
> deleted file mode 100644
> index 2b86a00e351d..000000000000
> --- a/Documentation/devicetree/bindings/watchdog/brcm,kona-wdt.txt
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -Broadcom Kona Family Watchdog Timer
> ------------------------------------
> -
> -This watchdog timer is used in the following Broadcom SoCs:
> - BCM11130, BCM11140, BCM11351, BCM28145, BCM28155
> -
> -Required properties:
> - - compatible = "brcm,bcm11351-wdt", "brcm,kona-wdt";
> - - reg: memory address & range
> -
> -Example:
> - watchdog@35002f40 {
> - compatible = "brcm,bcm11351-wdt", "brcm,kona-wdt";
> - reg = <0x35002f40 0x6c>;
> - };
> diff --git a/Documentation/devicetree/bindings/watchdog/brcm,kona-wdt.yaml b/Documentation/devicetree/bindings/watchdog/brcm,kona-wdt.yaml
> new file mode 100644
> index 000000000000..ffc4870bdb57
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/brcm,kona-wdt.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/brcm,kona-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom Kona Family Watchdog Timer
> +
> +description: |
> + This watchdog timer is used in the following Broadcom SoCs:
> + BCM11130, BCM11140, BCM11351, BCM28145, BCM28155
> +
> +maintainers:
> + - Rob Herring <robh@xxxxxxxxxx>
No, it should be device maintainer.
> +
> +allOf:
> + - $ref: "watchdog.yaml#"
Drop quotes.
> +
> +properties:
> + compatible:
> + enum:
> + - brcm,bcm11351-wdt
> + - brcm,kona-wdt
> +
> + reg:
> + maxItems: 1
> + description: memory address & range
Drop description.
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + watchdog@35002f40 {
> + compatible = "brcm,bcm11351-wdt";
> + reg = <0x35002f40 0x6c>;
> + };
> + - |
> + watchdog@35002f40 {
Does not look like you tested the bindings. Please run `make
dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
> + compatible = "brcm,kona-wdt";
> + reg = <0x35002f40 0x6c>;
> + };
Keep only one example.
Best regards,
Krzysztof
