On Tue, 2023-03-14 at 10:10 +0100, AngeloGioacchino Del Regno wrote: > Il 09/03/23 14:54, Garmin.Chang ha scritto: > > Add MT8188 imgsys clock controllers which provide clock gate > > control for image IP blocks. > > > > Signed-off-by: Garmin.Chang <Garmin.Chang@xxxxxxxxxxxx> > > --- > > drivers/clk/mediatek/Makefile | 2 +- > > drivers/clk/mediatek/clk-mt8188-img.c | 110 > > ++++++++++++++++++++++++++ > > 2 files changed, 111 insertions(+), 1 deletion(-) > > create mode 100644 drivers/clk/mediatek/clk-mt8188-img.c > > > > diff --git a/drivers/clk/mediatek/Makefile > > b/drivers/clk/mediatek/Makefile > > index fb66d25e98fd..935805632018 100644 > > --- a/drivers/clk/mediatek/Makefile > > +++ b/drivers/clk/mediatek/Makefile > > @@ -93,7 +93,7 @@ obj-$(CONFIG_COMMON_CLK_MT8186) += clk-mt8186- > > mcu.o clk-mt8186-topckgen.o clk-mt > > clk-mt8186-cam.o clk-mt8186-mdp.o > > clk-mt8186-ipe.o > > obj-$(CONFIG_COMMON_CLK_MT8188) += clk-mt8188-apmixedsys.o clk- > > mt8188-topckgen.o \ > > clk-mt8188-peri_ao.o clk-mt8188- > > infra_ao.o \ > > - clk-mt8188-cam.o clk-mt8188-ccu.o > > + clk-mt8188-cam.o clk-mt8188-ccu.o > > clk-mt8188-img.o > > imgsys can go under a different config option. > > I won't send any more comments on the other 10 clocks for the same > reason, so > please split the clocks as needed. Check the others like MT8186, > MT8192, MT8195. > Thank you for your suggestions. Ok, I will modify all mt8188 clocks about this in v7. Thanks, Best Regards, Garmin