On 31.03.2023 02:43, Dmitry Baryshkov wrote:
> On 20/01/2023 19:22, Konrad Dybcio wrote:
>> SM8250 has (at least) four GPU speed bins. With the support added on the
>> driver side, wire up bin detection in the DTS to restrict lower-quality
>> SKUs from running at frequencies they were not validated at.
>>
>> Tested-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx> # On Sony Xperia 5 II (speed bin 0x7)
>> Reviewed-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
>> ---
>> arch/arm64/boot/dts/qcom/sm8250.dtsi | 23 ++++++++++++++++++++++-
>> 1 file changed, 22 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
>> index 059c83003fb6..95f1a6afcd43 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
>> @@ -981,6 +981,18 @@ ipcc: mailbox@408000 {
>> #mbox-cells = <2>;
>> };
>> + qfprom: efuse@784000 {
>> + compatible = "qcom,sm8250-qfprom", "qcom,qfprom";
>> + reg = <0 0x00784000 0 0x8ff>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> +
>> + gpu_speed_bin: gpu_speed_bin@19b {
>> + reg = <0x19b 0x1>;
>> + bits = <5 3>;
>> + };
>> + };
>> +
>> rng: rng@793000 {
>> compatible = "qcom,prng-ee";
>> reg = <0 0x00793000 0 0x1000>;
>> @@ -2576,49 +2588,58 @@ gpu: gpu@3d00000 {
>> qcom,gmu = <&gmu>;
>> + nvmem-cells = <&gpu_speed_bin>;
>> + nvmem-cell-names = "speed_bin";
>> +
>> status = "disabled";
>> zap-shader {
>> memory-region = <&gpu_mem>;
>> };
>> - /* note: downstream checks gpu binning for 670 Mhz */
>> gpu_opp_table: opp-table {
>> compatible = "operating-points-v2";
>> opp-670000000 {
>> opp-hz = /bits/ 64 <670000000>;
>> opp-level = <RPMH_REGULATOR_LEVEL_NOM_L1>;
>> + opp-supported-hw = <0x6>;
>
> opp-supported-hw = <0xa>; /* 3 & 1 */
>
>> };
>> opp-587000000 {
>> opp-hz = /bits/ 64 <587000000>;
>> opp-level = <RPMH_REGULATOR_LEVEL_NOM>;
>> + opp-supported-hw = <0x7>;
>
> opp-supported-hw = <0xb>; /* 3, 1, 0 */
The values here are correct, however I remapped the bins against
qcom logic.. will fix that in the next rev!
Konrad
>
>
>> };
>> opp-525000000 {
>> opp-hz = /bits/ 64 <525000000>;
>> opp-level = <RPMH_REGULATOR_LEVEL_SVS_L2>;
>> + opp-supported-hw = <0xf>;
>> };
>> opp-490000000 {
>> opp-hz = /bits/ 64 <490000000>;
>> opp-level = <RPMH_REGULATOR_LEVEL_SVS_L1>;
>> + opp-supported-hw = <0xf>;
>> };
>> opp-441600000 {
>> opp-hz = /bits/ 64 <441600000>;
>> opp-level = <RPMH_REGULATOR_LEVEL_SVS_L0>;
>> + opp-supported-hw = <0xf>;
>> };
>> opp-400000000 {
>> opp-hz = /bits/ 64 <400000000>;
>> opp-level = <RPMH_REGULATOR_LEVEL_SVS>;
>> + opp-supported-hw = <0xf>;
>> };
>> opp-305000000 {
>> opp-hz = /bits/ 64 <305000000>;
>> opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS>;
>> + opp-supported-hw = <0xf>;
>> };
>> };
>> };
>
