Hi Jeremy, Thanks for the change, especially IBI features in other threads. >From my understanding, ASPEED AST2600 is a SoC which uses Synopsys' I3C IP core, and several different registers, especially the pull-up resistor. If so, I am wondering if this is the right place to add ast2600-i3c-master.c, given that all current three xxx-i3c-master.c drivers in this directory are from IP providers directly. What about moving it under ~/driver/soc/? Thanks Zenghu Chen On Thu, Mar 30, 2023 at 3:22 AM Jeremy Kerr <jk@xxxxxxxxxxxxxxxxxxxx> wrote: > > This series adds a new i3c controller driver, for the ASPEED AST2600 13c > SoC peripheral. This device is very similar to the dw i3c controller, so > we implement this by adding a little platform abstraction to the dw > driver, and then a platform implementation for ast2600. > > v2: This is a rework from an earlier series that implemented this as > part of the dw driver; I have adopted Ben Dooks' suggestion to split > into a new driver + exported hooks from the dw base. > > As always: comments, queries etc. are most welcome. > > Cheers, > > > Jeremy > > Jeremy Kerr (3): > i3c: dw: Add infrastructure for platform-specific implementations > dt-bindings: i3c: Add AST2600 i3c controller > i3c: ast2600: Add AST2600 platform-specific driver > > .../bindings/i3c/aspeed,ast2600-i3c.yaml | 72 ++++++++ > MAINTAINERS | 6 + > drivers/i3c/master/Kconfig | 14 ++ > drivers/i3c/master/Makefile | 1 + > drivers/i3c/master/ast2600-i3c-master.c | 169 ++++++++++++++++++ > drivers/i3c/master/dw-i3c-master.c | 76 ++++---- > drivers/i3c/master/dw-i3c-master.h | 55 ++++++ > 7 files changed, 360 insertions(+), 33 deletions(-) > create mode 100644 Documentation/devicetree/bindings/i3c/aspeed,ast2600-i3c.yaml > create mode 100644 drivers/i3c/master/ast2600-i3c-master.c > create mode 100644 drivers/i3c/master/dw-i3c-master.h > > -- > 2.39.2 >
