On 3/28/2023 10:29 PM, Stephen Boyd wrote:
Quoting Devi Priya (2023-03-27 23:15:35)
On 3/27/2023 10:18 PM, Stephen Boyd wrote:
Quoting Devi Priya (2023-03-27 06:27:16)
diff --git a/drivers/clk/qcom/gcc-ipq9574.c b/drivers/clk/qcom/gcc-ipq9574.c
new file mode 100644
index 000000000000..b2a2d618a5ec
--- /dev/null
+++ b/drivers/clk/qcom/gcc-ipq9574.c
@@ -0,0 +1,4248 @@
+// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+/*
+ * Copyright (c) 2023 The Linux Foundation. All rights reserved.
+ */
+
+#include <linux/kernel.h>
+#include <linux/err.h>
+#include <linux/platform_device.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_device.h>
What is this include for?
This include actually don't seem necessary. But, I see that of.h &
platform_device.h are being included via of_device.h
Would you suggest to drop of_device.h or the other two
headers instead?
Include headers for things you use. Don't try to omit includes if you
see that a header includes other headers that you're using.
Sure, got it!
Regards,
Devi Priya
