On 07/03/2023 12:28, Okan Sahin wrote: > MFD driver for MAX77541/MAX77540 to enable its sub > devices. Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 > > The MAX77541 is a multi-function devices. It includes > buck converter and ADC. > > The MAX77540 is a high-efficiency buck converter > with two 3A switching phases. > > They have same regmap except for ADC part of MAX77541. > > +static int max77541_probe(struct i2c_client *client) > +{ > + const struct i2c_device_id *id = i2c_client_get_device_id(client); > + struct device *dev = &client->dev; > + struct max77541 *max77541; > + > + max77541 = devm_kzalloc(dev, sizeof(*max77541), GFP_KERNEL); > + if (!max77541) > + return -ENOMEM; > + > + i2c_set_clientdata(client, max77541); > + max77541->i2c = client; > + > + max77541->chip = device_get_match_data(dev); > + if (!max77541->chip) > + max77541->chip = (struct chip_info *)id->driver_data; You have odd indentation/coding style before '='. Use Linux coding style. Best regards, Krzysztof
