On 11/20/2014 02:38 PM, Jacek Anaszewski wrote:
Hi Pavel, On 11/20/2014 02:17 PM, Pavel Machek wrote:Add attributes neccessary for LED flashes to devicetree/bindings/leds/common.txt . This will allow me to add device tree support for adp1653 i2c flash LED driver, and allow Jacek Anaszewski to add support for more LED drivers.. Signed-off-by: Pavel Machek <pavel@xxxxxx> diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt index 2d88816..e9acbbc 100644 --- a/Documentation/devicetree/bindings/leds/common.txt +++ b/Documentation/devicetree/bindings/leds/common.txt @@ -14,6 +14,15 @@ Optional properties for child nodes: "ide-disk" - LED indicates disk activity "timer" - LED flashes at a fixed, configurable rate +- max-microamp : maximum intensity in microamperes of the LED + (torch LED for flash devices) +- flash-max-microamp : maximum intensity in microamperes of the + flash LED; it is mandatory if the LED should + support the flash mode +- flash-timeout-microsec : timeout in microseconds after which the flash + LED is turned off + + Examples: system-status { @@ -21,3 +30,10 @@ system-status { linux,default-trigger = "heartbeat"; ... }; + +camera-flash { + label = "Flash"; + max-microamp = <50000>; + flash-max-microamp = <320000>; + flash-timeout-microsec = <500000>; +}Why did you omit indicator-pattern?
Actually, we've agreed with Sakari that we can handle indicator-pattern later. I would remove references to you, me and adp1653 driver from the commit message and mention that this modifications adjust the led common bindings to the LED Flash class that is to be added. Regards, Jacek -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
