Hi Maxime On Wed, 29 Mar 2023 at 17:46, Maxime Ripard <maxime@xxxxxxxxxx> wrote: > > On Wed, Mar 29, 2023 at 05:28:28PM +0100, Dave Stevenson wrote: > > On Wed, 29 Mar 2023 at 14:19, Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> wrote: > > > > > > DSI sink devices typically send the MIPI-DCS commands to the DSI host > > > via general MIPI_DSI_DCS read and write API. > > > > > > The classical DSI sequence mentioned that the DSI host receives MIPI-DCS > > > commands from the DSI sink first in order to switch HS mode properly. > > > Once the DSI host switches to HS mode any MIPI-DCS commands from the > > > DSI sink are unfunctional. > > > > That statement contradicts the spec. > > The DSI spec section 8.11.1 Transmission Packet Sequences says that > > during any BLLP (Blanking or Low Power) period the host can do any of: > > - remain in LP-11 > > - transmit one or more non-video packets from host to peripheral in escape mode > > - transmit one or more non-video packets from host to peripheral in > > using HS mode > > - receive one or more packets from peripheral to host using escape mode > > - transmit data on a different virtual channel. > > > > Indeed if the sink doesn't set MIPI_DSI_MODE_LPM / > > MIPI_DSI_MSG_USE_LPM, then the expectation is that any data transfer > > will be in HS mode. > > > > That makes me confused as to the need for this patch. > > Yeah, and it looks like that would break the expectation that, in > enable, a bridge can expect its controller to be in HS mode. > > I think that was Jagan is trying to do is to work around an issue with > the Allwinner DSI driver: > https://elixir.bootlin.com/linux/v6.3-rc4/source/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c#L775 > > This is working mostly fine since we only have panel support and can > control that, but with bridge support added in the latest patch, then it > probably doesn't work anymore. > > The proper way to fix this isn't to put more logic into the framework, > it's to make the DSI driver behave as expected by KMS. > > Unfortunately, that controller is not documented, so it's not clear to > me how we can fix it. > > IIRC, it's basically a state machine where you would encode the > transitions between one DSI state and the next depending on what your > expectations are. > > I think there's two problem with the driver that need to be addressed: > > - First the driver will drop back to LP11 mode to submit commands. I > don't think it's needed and could even be hurtful to the video > stream if it was to happen during HS mode: > https://elixir.bootlin.com/linux/v6.3-rc4/source/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c#L877 > > - And then, it looks like, in HSD mode, we never get to go to the > state LPTX is in (LPDT). It would be interesting to test whether > adding a transition to that state makes it work or not. Ooh, not fun. I'll agree with your assessment - it looks like sunxi driver has significant limitations on the modes of operation it supports. If there is no information on sending HS commands, I wonder if it's possible to note the video state in transfer and stop video, send the command, and resume video again. Ugly as heck, but possibly the only real option without documentation. It does raise the question of do other blocks (eg crtc) need to be stopped as well, or does stopping the PHY and/or DSI block stop the pixel data getting clocked out. I can only guess at the meaning of the enum sun6i_dsi_start_inst and enum sun6i_dsi_inst_id states. LPTX and LPRX are largely obvious, but HSC(ommand) and HSD(ata) perhaps? I thought on initial reading that the setup in sun6i_dsi_start made sense as a sequence of commands, but looking closer at the bitmasking and shifting I'm not so convinced. Are the DSI_INST_ID_xxx defines shifts or the bitmask values to or in, as they get used for both. Dave
