On 28/03/2023 13:53, zhuyinbo wrote: > > > 在 2023/3/28 下午7:35, Andi Shyti 写道: >> Hi Yinbo, >> >> before submitting the patches for review... can you please run >> checkpatch.pl on them? > yes, I had used checkpatch.pl to check and no any errors and warnings. > > user@user-pc:~/workspace/test/code/www.kernel.org/linux$ > ./scripts/checkpatch.pl *.patch > ----------------------- > 0000-cover-letter.patch > ----------------------- > total: 0 errors, 0 warnings, 0 lines checked > > 0000-cover-letter.patch has no obvious style problems and is ready for > submission. > ------------------------------------------- > 0001-dt-bindings-spi-add-loongson-spi.patch > ------------------------------------------- > Traceback (most recent call last): > File "scripts/spdxcheck.py", line 6, in <module> > from ply import lex, yacc > ModuleNotFoundError: No module named 'ply' > total: 0 errors, 0 warnings, 55 lines checked > > 0001-dt-bindings-spi-add-loongson-spi.patch has no obvious style > problems and is ready for submission. > --------------------------------------------------------------- > 0002-spi-loongson-add-bus-driver-for-the-loongson-spi-con.patch > --------------------------------------------------------------- > Traceback (most recent call last): > File "scripts/spdxcheck.py", line 6, in <module> > from ply import lex, yacc > ModuleNotFoundError: No module named 'ply' > Traceback (most recent call last): > File "scripts/spdxcheck.py", line 6, in <module> > from ply import lex, yacc > ModuleNotFoundError: No module named 'ply' > Traceback (most recent call last): > File "scripts/spdxcheck.py", line 6, in <module> > from ply import lex, yacc > ModuleNotFoundError: No module named 'ply' > Traceback (most recent call last): > File "scripts/spdxcheck.py", line 6, in <module> > from ply import lex, yacc > ModuleNotFoundError: No module named 'ply' You have errors here... Fix your setup for spdx check. Best regards, Krzysztof