Quoting Bartosz Golaszewski (2023-03-28 12:36:27) > diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig > index 449bc8314d21..5e1919738aeb 100644 > --- a/drivers/clk/qcom/Kconfig > +++ b/drivers/clk/qcom/Kconfig > @@ -437,6 +437,14 @@ config SA_GCC_8775P > Say Y if you want to use peripheral devices such as UART, SPI, > I2C, USB, UFS, SDCC, etc. > > +config SA_GPUCC_8775P > + tristate "SA8775P Graphics clock controller" > + select SA_GCC_8775P Should select QCOM_GDSC as well. > + help > + Support for the graphics clock controller on SA8775P devices. > + Say Y if you want to support graphics controller devices and > + functionality such as 3D graphics. > + > config SC_GCC_7180 > tristate "SC7180 Global Clock Controller" > select QCOM_GDSC > diff --git a/drivers/clk/qcom/gpucc-sa8775p.c b/drivers/clk/qcom/gpucc-sa8775p.c > new file mode 100644 > index 000000000000..46d73bd0199b > --- /dev/null > +++ b/drivers/clk/qcom/gpucc-sa8775p.c > @@ -0,0 +1,633 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2021-2022, Qualcomm Innovation Center, Inc. All rights reserved. > + * Copyright (c) 2023, Linaro Limited > + */ > + > +#include <linux/clk.h> Is this include used? If not, remove it as this is a clk provider and not a clk consumer.